Flow.Launcher.Core/Resource/Internationalization.cs (1)

1-1: UTF‑8 BOM slipped in.

A BOM was introduced; keep file encoding consistent with the repo (usually UTF‑8 without BOM).

-using System;
+using System;

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Flow.Launcher.Core/Resource/Internationalization.cs (2)

165-169: Serialize language changes and marshal resource ops to UI thread.

Rapid selection changes can overlap ChangeLanguageAsync, racing on _oldResources and Application.Current.Resources.

Suggested pattern (outside changed lines):

// Field
private readonly SemaphoreSlim _langChangeGate = new(1, 1);

// In ChangeLanguageAsync
await _langChangeGate.WaitAsync();
try
{
    await Application.Current.Dispatcher.InvokeAsync(RemoveOldLanguageFiles);
    if (language != AvailableLanguages.English)
        await Application.Current.Dispatcher.InvokeAsync(() => LoadLanguage(language));

    ChangeCultureInfo(language.LanguageCode);

    if (updateMetadata)
        await Task.Run(UpdatePluginMetadataTranslations);
}
finally
{
    _langChangeGate.Release();
}

Also applies to: 186-203

---

1-1: Unintended UTF‑8 BOM.

A BOM was added. If the repo targets utf-8 without BOM (common in .editorconfig), please remove to avoid noisy diffs.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Flow.Launcher.Core/Resource/Internationalization.cs (2)

1-1: Avoid committing a UTF‑8 BOM in C# files.

It creates noisy diffs and can confuse some tooling. Prefer UTF‑8 without BOM.

---

310-319: Fix log message variable.

It logs <{path}> when the missing file is actually english. Improves diagnostics.

Apply this diff:

-                        API.LogError(ClassName, $"Default English Language path can't be found <{path}>");
+                        API.LogError(ClassName, $"Default English Language path can't be found <{english}>");

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Flow.Launcher.Core/Resource/Internationalization.cs (2)

33-33: Lock scope: make the semaphore static (or confirm singleton) and consider disposal.

If multiple Internationalization instances can exist, per‑instance locks won’t serialize language changes globally. Prefer a static semaphore or confirm there’s only one instance for app lifetime. Disposal is optional for app‑lifetime objects but silences analyzers.

Apply if needed:

-        private readonly SemaphoreSlim _langChangeLock = new(1, 1);
+        private static readonly SemaphoreSlim _langChangeLock = new(1, 1);

To verify instance count, run:

#!/bin/bash
# Find construction sites of Internationalization
rg -nP --type=cs -C2 '\bnew\s+Internationalization\s*\('

---

189-212: Catch/log exceptions to avoid unobserved task faults; avoid Task.Run here.

ChangeLanguage fire‑and‑forgets this Task (Line 166). Without a catch, faults become unobserved. Also, UpdatePluginMetadataTranslations is synchronous; calling it via Task.Run adds overhead and makes thread affinity unclear.

         private async Task ChangeLanguageAsync(Language language, bool updateMetadata = true)
         {
-            await _langChangeLock.WaitAsync();
+            await _langChangeLock.WaitAsync();
             try
             {
                 // Remove old language files and load language
                 RemoveOldLanguageFiles();
                 if (language != AvailableLanguages.English)
                 {
                     LoadLanguage(language);
                 }

                 // Change culture info
                 ChangeCultureInfo(language.LanguageCode);

                 if (updateMetadata)
                 {
-                    // Raise event for plugins after culture is set
-                    await Task.Run(UpdatePluginMetadataTranslations);
+                    // Raise event for plugins after culture is set
+                    UpdatePluginMetadataTranslations(); // run on caller thread for predictable affinity
                 }
             }
+            catch (Exception e)
+            {
+                API.LogException(ClassName, "ChangeLanguageAsync failed", e);
+            }
             finally
             {
                 _langChangeLock.Release();
             }
         }

Also confirm UpdatePluginMetadataTranslations is safe on the calling thread (likely UI).

Flow.Launcher.Core/Resource/Internationalization.cs (3)

1-1: Nit: UTF‑8 BOM churn — confirm repo policy.

If the repo doesn’t mandate BOM for C# files, consider removing it to avoid diff noise.

Do we have an .editorconfig rule requiring BOM for .cs files?

---

203-207: Update loop exits early on non‑i18n plugins — fix premature return.

UpdatePluginMetadataTranslations currently returns on the first plugin that isn’t IPluginI18n, skipping the rest. Use continue.

-                if (p.Plugin is not IPluginI18n pluginI18N) return;
+                if (p.Plugin is not IPluginI18n pluginI18N) continue;

---

57-71: System language detection overwrites matches with default — set default before the loop and don’t reset after.

As written, any match found is immediately overridden by the final assignment to DefaultLanguageCode.

-            // Try to find a match in the available languages list
+            // Default to English; try to find a match in the available languages list
+            SystemLanguageCode = DefaultLanguageCode;
             foreach (var language in availableLanguages)
             {
                 var languageCode = language.LanguageCode;
                 if (string.Equals(languageCode, twoLetterCode, StringComparison.OrdinalIgnoreCase) ||
                     string.Equals(languageCode, threeLetterCode, StringComparison.OrdinalIgnoreCase) ||
                     string.Equals(languageCode, fullName, StringComparison.OrdinalIgnoreCase))
                 {
                     SystemLanguageCode = languageCode;
+                    break;
                 }
             }
-
-            SystemLanguageCode = DefaultLanguageCode;

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3572
File: Flow.Launcher/App.xaml.cs:214-216
Timestamp: 2025-07-06T12:21:37.947Z
Learning: In Flow Launcher, the UpdatePluginManifestAsync method in PluginsManifest.cs already has comprehensive internal try-catch handling that logs exceptions and returns false on failure rather than throwing, making external try-catch wrappers unnecessary.